Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIMAPP-1546] Evidence upload content updates #1302

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

hiboabd
Copy link
Contributor

@hiboabd hiboabd commented Jan 7, 2025

Description of change

Updates content on the evidence upload screen as per ticket

Link to relevant ticket

https://dsdmoj.atlassian.net/browse/CRIMAPP-1546

Notes for reviewer

I would like to run the formatting of the text by content/design before merging so sticking a do not merge tag on this pr

Screenshots of changes (if applicable)

Before changes:

After changes:

Screenshot 2025-01-07 at 14 30 21 Screenshot 2025-01-07 at 14 30 15 Screenshot 2025-01-07 at 14 29 46 Screenshot 2025-01-07 at 14 29 57

Client remanded in custody warning text
Screenshot 2025-01-21 at 13 46 51

Trial in crown court warning text
Screenshot 2025-01-21 at 13 50 29

How to manually test the feature

Go to the evidence upload screen and test the content is as expected for the following application types

  • Crown court application
  • When the client is remanded
  • Change in financial circumstances
  • When no supporting evidence is required (e.g. under 18)
  • When evidence is required (client, partner and client and partner)

@hiboabd hiboabd marked this pull request as ready for review January 7, 2025 17:08
@hiboabd hiboabd requested a review from a team as a code owner January 7, 2025 17:08
@hiboabd hiboabd added the do not merge Do not merge yet, work in progress label Jan 7, 2025
Copy link
Contributor

@EdwinKruglov EdwinKruglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like how you've split the edit page into more manageable chunks!

@hiboabd hiboabd removed the do not merge Do not merge yet, work in progress label Jan 21, 2025
@hiboabd hiboabd merged commit e0c7d69 into main Jan 21, 2025
7 checks passed
@hiboabd hiboabd deleted the CRIMAPP-1546-evidence-upload-content-updates branch January 21, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants