Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIMAPP-1516] Property ownership validation #1303

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

EdwinKruglov
Copy link
Contributor

@EdwinKruglov EdwinKruglov commented Jan 8, 2025

Description of change

This changes adds validation in the capital section to check whether the client's usual residence is declared as a property. A new question is asked to allow the user to either add a new property with a matching home address or change where the client usually lives.

The changes are behind the feature flag property_ownership_validation.

Link to relevant ticket

CRIMAPP-1516

Screenshots of changes (if applicable)

After changes:

image

How to manually test the feature

  1. Create an application and when asked 'Where does your client usually live?' answer 'In a property they own', 'In a property their partner owns', or 'In a property they and their partner both own'.
  2. At the capital section, when asked about which assets the client (and/or partner) owns, answer 'They do not own any of these assets'.
  3. You should see the new question.

The new question should also be triggered after answering 'No' to 'Do you want to add another asset?' if there is no asset that matches the home address.
The new question (and validation) shouldn't be triggered if the client has a partner and they live in a property owned by the partner and there's a conflict of interest.

@EdwinKruglov EdwinKruglov requested a review from a team as a code owner January 8, 2025 09:45
@EdwinKruglov EdwinKruglov force-pushed the crimapp-1516-property-ownership-validation branch from 41083bf to b4841b3 Compare January 8, 2025 09:53
Copy link
Contributor

@hiboabd hiboabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left one comment regarding the error message presentation

@EdwinKruglov EdwinKruglov force-pushed the crimapp-1516-property-ownership-validation branch 3 times, most recently from 9252e96 to bb7c017 Compare January 10, 2025 12:32
@EdwinKruglov EdwinKruglov force-pushed the crimapp-1516-property-ownership-validation branch from bb7c017 to 7f707b3 Compare January 10, 2025 12:34
@EdwinKruglov EdwinKruglov merged commit def1beb into main Jan 10, 2025
7 checks passed
@EdwinKruglov EdwinKruglov deleted the crimapp-1516-property-ownership-validation branch January 10, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants