[CRIMAPP-1403] Update payment fieldset form validation #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiboabd
changed the title
EdwinKruglov
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes error message handling on payment forms (income payment, income benefit and outgoing payment) and updates error message text
The validation for these forms have been moved to a shared class in order to display the payment type in the error message and apply these errors per fieldset
Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMAPP-1403
Notes for reviewer
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature