Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIMAPP-1558] Apply error styling to autocomplete input field #1313

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

hiboabd
Copy link
Contributor

@hiboabd hiboabd commented Jan 16, 2025

Description of change

Fixes issue where the red outline was not appearing around the input field for accessible autocomplete components when there is an error message as per gov uk design conventions

Link to relevant ticket

https://dsdmoj.atlassian.net/browse/CRIMAPP-1558

Notes for reviewer

Screenshots of changes (if applicable)

Before changes:

Screenshot 2025-01-16 at 17 08 53

After changes:

Screenshot 2025-01-16 at 16 51 21 Screenshot 2025-01-16 at 16 52 26

How to manually test the feature

@hiboabd hiboabd marked this pull request as ready for review January 16, 2025 17:09
@hiboabd hiboabd requested a review from a team as a code owner January 16, 2025 17:09
@hiboabd hiboabd merged commit b4f6a0d into main Jan 20, 2025
7 checks passed
@hiboabd hiboabd deleted the CRIMAPP-1558-accessible-autocomplete-error-styling branch January 20, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants