Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-annotate flag to the pip-compile pre-commit hook #58

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

said-moj
Copy link
Contributor

What does this pull request do?

Add --no-annotate flag to the pip-compile pre-commit hook.

Any other changes that would benefit highlighting?

Without this flag, the path that some dependencies are annotated with will differ on the pipeline which will cause differences on the auto generated files.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

Without this flag, the path that some dependencies are annotated with
will differ on the pipeline which will cause differences on the auto generated files
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BenMillar-MOJ BenMillar-MOJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍
Will keep an eye on the pip-compile thread to see how it resolves

@said-moj said-moj merged commit 4fdb63a into main Nov 4, 2024
13 of 14 checks passed
@said-moj said-moj deleted the fix-pip-compile-pre-commit-hook branch November 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants