Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docs when pushing to dev branch #62

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Build docs when pushing to dev branch #62

wants to merge 5 commits into from

Conversation

BenMillar-MOJ
Copy link
Contributor

@BenMillar-MOJ BenMillar-MOJ commented Nov 15, 2024 •
edited
Loading

What does this pull request do?

  • Fixes issues where the documentation failed to build on main due to each page requiring a H1
  • Now builds and checks the docs as part of the feature branch workflow, so this doesn't happen again. The docs are still only published on a push to main.

Any other changes that would benefit highlighting?

Intentionally left blank.

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

TawneeOwl
TawneeOwl approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@said-moj said-moj said-moj approved these changes

@TawneeOwl TawneeOwl TawneeOwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMillar-MOJ @said-moj @TawneeOwl