Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIN-1115 and MIN-1116 | VULNERABILITY | Fix Update LBE issues #27

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

ljttl3q04t
Copy link
Contributor

@ljttl3q04t ljttl3q04t commented Jun 10, 2024

This PR aims to:

ON-CHAIN:

  • MIN-1116 Prevent from updating LBE ID
  • MIN-1115 Prevent from updating LBE when it has been cancelled.

OFF-CHAIN:

  • Add Build Tx Update LBE
  • Add test Update LBE

Copy link

linear bot commented Jun 10, 2024

MIN-1024 Vulnerability

I create this task for Vulnerability feedback

@ljttl3q04t ljttl3q04t requested a review from m1n999999 June 10, 2024 07:32
@ljttl3q04t ljttl3q04t changed the title MIN-1024 | VULNERABILITY | prevent updating the LBE when it has been cancelled. MIN-1115 | VULNERABILITY | prevent updating the LBE when it has been cancelled. Jun 10, 2024
Copy link

linear bot commented Jun 10, 2024

MIN-1115 Medium | Edge case of update LBE

Before discovery phase start, project owner can update LBE.

Step 1: Create normal LBE

Step 2: Cancel LBE

Step 3: Collect Sellers, Manager

Step 4: Update LBE, make is_cancelled = False

At this step, LBE is set up with invalid structure.

@ljttl3q04t ljttl3q04t changed the title MIN-1115 | VULNERABILITY | prevent updating the LBE when it has been cancelled. MIN-1115 and MIN-1116 | VULNERABILITY | Fix Update LBE issues Jun 10, 2024
Copy link

linear bot commented Jun 10, 2024

MIN-1116 Medium | Update Order | LBE ID can update

(base_asset, raise_asset) is the LBE ID. Once an LBE is created, its ID cannot be updated.

Step 1: Create a standard LBE

Step 2: Attempt to update the LBE with a different base_asset or raise_assset

At this step, the LBE should be prevented from being updated to ensure consistency.

validators/treasury.ak Outdated Show resolved Hide resolved
@m1n999999 m1n999999 merged commit 1791f48 into main Jun 11, 2024
1 check passed
@m1n999999 m1n999999 deleted the tony/fix/update-lbe branch June 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants