Use fix multiprocessing bug on macOS where qsize() is not implemented
#1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praseodym
reviewed
Jul 11, 2023
boefjes/boefjes/app.py
Outdated
| self.handling_tasks = mp.Manager().dict() | ||
| manager = mp.Manager() | ||
|
|
||
| self.task_queue = manager.Queue() # multiprocessing.Queue() will not work on OSX, see mp.Queue.qsize() |
There was a problem hiding this comment.
Renamed to macOS since then :)
ammar92
previously approved these changes
Jul 11, 2023
…le-issues' into fix/scheduler-client-factor-pickle-issues
Donnype
changed the title
qsize() is not implemented
|
@noamblitz could you see if the problem persists? |
underdarknl
approved these changes
Jul 12, 2023
jpbruinsslot
added a commit
that referenced
this pull request
Jul 24, 2023
* main: Fix robot test (#1420) Use the correct clearance level variable in organization member list template (#1427) Fix translation in Debian package (#1432) Reschedule tasks when no results in bytes are found after grace period (#1410) Don't scan hostname nmap in nmap boefje (#1415) Add and use our own CVE API (#1383) Add `task_id` as a query parameter to the `GET /origins` endpoint (#1414) Remove member group checks and check for permission instead (#1275) Bump cryptography from 41.0.0 to 41.0.2 in /boefjes/boefjes/plugins/kat_ssl_certificates (#1396) Bump cryptography from 41.0.1 to 41.0.2 in /bytes (#1397) Build the Debian build image on the main branch (#1387) Add explicit `black` config to all modules (#1395) Fix <no title> in the user guide docs (#1391) Add configurable octpoes request timeout (#1382) Remove hardcoded clearance level in member list for superusers (#1390) Add Debian build depends for CVE API package (#1384) Add buttons to manual rerun tasks, both boefjes or normalizers (#1339) Use fix multiprocessing bug on macOS where `qsize()` is not implemented (#1374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should fix the MacOSX issues due to
qsize()not working (as documented in the library.. For the last 15 years..)Proof
Tested on my Mac, we could consider adding a matrix in github but this is probably overkill.
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.