Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scan hostname nmap in nmap boefje #1415

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Don't scan hostname nmap in nmap boefje #1415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81adbc1
Don't scan hostname nmap in nmap boefje
dekkers Jul 18, 2023
af4c4dd
Fix tests
dekkers Jul 18, 2023
760c2aa
Merge branch 'main' into dont-scan-hostname-nmap
dekkers Jul 19, 2023
8b2eee5
Merge branch 'main' into dont-scan-hostname-nmap
dekkers Jul 19, 2023
9311f2c
Merge branch 'main' into dont-scan-hostname-nmap
Darwinkel Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion boefjes/boefjes/plugins/kat_nmap/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def build_nmap_arguments(host: str, protocol: Protocol, top_ports: Optional[int]
"""Returns Nmap arguments to use based on protocol and top_ports for host."""
ip = ip_address(host)
args = [
"nmap",
"--open",
"-T4",
"-Pn",
Expand Down
8 changes: 0 additions & 8 deletions boefjes/tests/test_nmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ def test_nmap_arguments_tcp_top_150(self):
args = build_nmap_arguments("1.1.1.1", Protocol.TCP, 250)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -29,7 +28,6 @@ def test_nmap_arguments_tcp_top_150_ipv6(self):
args = build_nmap_arguments("2001:19f0:5001:23fe:5400:3ff:fe60:883b", Protocol.TCP, 250)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -51,7 +49,6 @@ def test_nmap_arguments_tcp_full(self):
args = build_nmap_arguments("1.1.1.1", Protocol.TCP, None)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -71,7 +68,6 @@ def test_nmap_arguments_tcp_full_ipv6(self):
args = build_nmap_arguments("2001:19f0:5001:23fe:5400:3ff:fe60:883b", Protocol.TCP, None)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -92,7 +88,6 @@ def test_nmap_arguments_udp_full(self):
args = build_nmap_arguments("1.1.1.1", Protocol.UDP, None)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -112,7 +107,6 @@ def test_nmap_arguments_udp_full_ipv6(self):
args = build_nmap_arguments("2001:19f0:5001:23fe:5400:3ff:fe60:883b", Protocol.UDP, None)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -133,7 +127,6 @@ def test_nmap_arguments_udp_top250(self):
args = build_nmap_arguments("1.1.1.1", Protocol.UDP, 250)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand All @@ -154,7 +147,6 @@ def test_nmap_arguments_udp_top250_ipv6(self):
args = build_nmap_arguments("2001:19f0:5001:23fe:5400:3ff:fe60:883b", Protocol.UDP, 250)
self.assertListEqual(
[
"nmap",
"--open",
"-T4",
"-Pn",
Expand Down