Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove unneeded tree lookups on ooi views #4032

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

underdarknl
Copy link
Contributor

Changes

Made sure the get_ooi is not overloaded to load a tree of (default) 9 deep.
Only load the shallow tree (depth 1) when we are trying to show the related objects and or findings tables.
Only load the full tree when showing the actual tree pages.

Issue link

You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.

Please add the link to the issue after "Closes".

Closes ...

Demo

Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.

QA notes

Make sure the Findings list, and related objects lists on an object detail page still load.
Make sure the tree views on an object detail page still load and is by default 9 levels deep (but can be changed via the form).
Make sure on the default OOI detail page, octopoes gets only a shallow (depth=1) tree call.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl underdarknl requested a review from a team as a code owner January 17, 2025 10:56
Comment on lines 151 to 152
if self.observed_at.date() == now.date():
return self.ooi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check still needed? the tree uses the self.observed_at property of the view anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants