Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct fmt version in dune-project #996

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

craigfe
Copy link
Member

@craigfe craigfe commented Apr 16, 2020

As of Dune 2.5.0, warnings are emitted if the (using lang <foo>) stanza is using a version higher than is supported. This gives us the following warning in CI:

File "dune-project", line 3, characters 11-14:
3 | (using fmt 1.2)
               ^^^
Warning: Version 1.2 of integration with automatic formatters is not
supported until version 1.11 of the dune language.
Supported versions of this extension in version 1.8 of the dune language:
- 1.0 to 1.1

As of Dune 2.5.0, warnings are emitted if the `(using lang <foo>)`
stanza is using a version higher than is supported. This gives us the
following warning in CI:

```
File "dune-project", line 3, characters 11-14:
3 | (using fmt 1.2)
               ^^^
Warning: Version 1.2 of integration with automatic formatters is not
supported until version 1.11 of the dune language.
Supported versions of this extension in version 1.8 of the dune language:
- 1.0 to 1.1
```
@samoht
Copy link
Member

samoht commented Apr 16, 2020

I guess an other option is to upgrade the version of the dune-project instead? Not sure what's the difference between fmt 1.1 and fmt 1.2.

@pascutto
Copy link
Contributor

1.2 enables support for dialects, which we don't use here. I think it's fine to downgrade thefmt version, everything will upgrade to dune.2.0.0+ with #991 eventually anyways.

@pascutto pascutto merged commit 9aafc16 into mirage:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants