Check file is sector aligned #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @Julow is probably interesting by this PR when he already did some works about that. |
|
I'm in favour of this. But could you fix the tests so that CI has a chance to pass? |
|
It seems to pass now except for the AppVeyor build which fails for unrelated reasons. While updating the test I thought about creating a new exception rather than using |
Yes, we should definitely delete AppVeyor. |
|
Maybe worth to replace AppVeyor by GitHub action (so we don't loose testing on windows)? |
Otherwise we have to make up non-existing bytes, and that's a mess.
Not sure if `buffered` is relevant.
reynir
force-pushed
the
file-sector-aligned
branch
from
b29afc8 to
a6d00c6
Compare
The other tests don't do it so maybe it's fine!?
reynir
force-pushed
the
file-sector-aligned
branch
from
41dfc56 to
dbab1e4
Compare
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 15, 2022
CHANGES: * Raise an exception on connect if the file is not aligned to the `sector_size` (mirage/mirage-block-unix#117, @reynir) * Demote log to debug when an error is returned (mirage/mirage-block-unix#119 @reynir, fixes mirage/mirage-block-unix#109) * Remove io-page dependency (mirage/mirage-block-unix#118 @hannesm) * Add GitHub actions for testing on macos and windows (retire Appveyor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now you can attach to files which are not aligned with the sector size (often 512 bytes), and you only get a warning about this if you connect with
~buffered:false(not the default). Then mirage-block-unix on read will conjure up zero bytes to make up for the non-existing bytes. My opinion is that it's bad behavior to return bytes that aren't there on the disk.This change checks in
connectthat the file is sector-aligned, and simplifies thereadcode.See also Solo5/solo5#527.