Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#37 named by sheet #216

Merged
merged 101 commits into from
May 15, 2024
Merged

Feature/#37 named by sheet #216

merged 101 commits into from
May 15, 2024

Conversation

spoltier
Copy link
Member

Creating a new pull request for reviewing the combined preexisting and recent changes.
Original PR is #146.

Closes #37 , requires miraisolutions/xlconnect-java#33 to be merged.

@spoltier
Copy link
Member Author

I recommend hiding the whitespace at least for a first pass review, as some of the diffs are mostly whitespace unfortunately.
Screenshot from 2024-02-14 17-54-14

@spoltier spoltier force-pushed the feature/#37-named-by-sheet branch 2 times, most recently from 37548ad to c1ca107 Compare February 28, 2024 09:55
@spoltier spoltier force-pushed the feature/#37-named-by-sheet branch 2 times, most recently from 5a37351 to 74ebb4a Compare March 12, 2024 15:19
Copy link
Member

@martinstuder martinstuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spoltier spoltier force-pushed the feature/#37-named-by-sheet branch from 5e0a454 to 842a4f8 Compare April 10, 2024 12:41
@spoltier spoltier force-pushed the feature/#37-named-by-sheet branch from 6d5b5e0 to 97dc2d8 Compare May 7, 2024 08:07
@spoltier spoltier merged commit fa57988 into master May 15, 2024
5 checks passed
@spoltier spoltier deleted the feature/#37-named-by-sheet branch May 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readNamedRegion and Local (sheet scoped) Names ?
2 participants