Upgrade React to 18.2.0 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fperreault
changed the base branch from
develop
to
feature/update-react-deepair
fperreault
merged commit d12ec0e
into
mirror-effect-plus-protocol:feature/update-react-deepair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the project's React dependency to v18.2.0. The upgrade appears to have no negative impact on functionality on either the patient side or the admin side. A new warning does appear in the console, however:
`react.development.js:209 Warning: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.`
I believe this is related to the @hot-loader/react-dom dependency, which is no longer actively maintained. The solution would likely be to get rid of this dependency and switch to built-in react tooling.
This also includes some minor changes to the cases of import paths. On my linux system webpack could not resolve those imports due to the mismatch in case between the given path and the actual filename. I decided to leave the filenames as-is and just changed the import paths.