Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MilStdIconRenderer renders a too-large image for some hostile action points #27

Closed
eric79 opened this issue Mar 13, 2018 · 4 comments
Closed
Assignees

Comments

@eric79
Copy link
Contributor

eric79 commented Mar 13, 2018

When drawing the following action points with a hostile affiliation, the image that is returned is larger than it intends to be:

  • Contact Point
  • Decision Point
  • Waypoint

For example, here is what is returned from toDataUrl for Contact Point:

image

img.getImageBounds().width reports that it's 27 pixels wide,
but img.getImage().width reports that it's 150 pixels wide (which is true).

As an aside:

  1. It appears that the issue only appears for the hostile affiliation
  2. MilStdSVGRenderer doesn't seem to have the problem.

And by the way ... thanks for making this library available. It's pretty awesome.

@michael-spinelli michael-spinelli self-assigned this Mar 13, 2018
@michael-spinelli
Copy link
Contributor

Glad you like it.

What modifiers are you passing into the renderer?
I'm having trouble duplicating the issue

@eric79
Copy link
Contributor Author

eric79 commented Mar 13, 2018

Oh, sorry. Here are the details:

symbolID: GHGPGPPC----**X
modifiers: {SIZE: "40", ICON: false, SYMSTD: 1}

michael-spinelli pushed a commit that referenced this issue Mar 14, 2018
@michael-spinelli
Copy link
Contributor

fixed in release v0.3.31

@eric79
Copy link
Contributor Author

eric79 commented Mar 14, 2018

Woohoo! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants