Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use an id for custom categories #650

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Jul 22, 2022

When I add a custom emoji category, I cannot indicate a custom id, so a default one is used what is a bit uncomfortable when I have to fill the categories array.

Current case:

init({
    ...,
    custom: [{ name: "Basic", emojis: [ … ] }],
    categories: ["custom_1"]
})

After this change:

init({
    ...,
    custom: [{ id: "basic", name: "Basic", emojis: [ … ] }],
    categories: ["basic"]
})

@EtienneLem EtienneLem merged commit d2f1018 into missive:main Jul 25, 2022
@EtienneLem
Copy link
Member

Totally makes sense, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants