Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): redis から取得できない過去のチャンネル投稿はDBから取得 #10539

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

futchitwo
Copy link
Contributor

What

Why

fa67fb4 で部分的に解決したため該当 issue は閉じられたが、redisに1つでも新しい投稿があると過去の投稿が参照できなくなるため。

Additional info (optional)

sinceDate, sinceId が条件にあるときはDBから取得するようにしているが、redis にある投稿のみにしてもいいかも (since系ではredisになかったらDBから取得、みたいな分岐は難しそう)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 8, 2023
@github-actions github-actions bot requested review from EbiseLutica and rinsuki April 8, 2023 22:53
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #10539 (1115962) into develop (7a33c5d) will increase coverage by 19.66%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop   #10539       +/-   ##
============================================
+ Coverage    75.04%   94.71%   +19.66%     
============================================
  Files          885        2      -883     
  Lines        87045      454    -86591     
  Branches      5877       59     -5818     
============================================
- Hits         65322      430    -64892     
+ Misses       21723       24    -21699     

see 883 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 038365b into misskey-dev:develop Apr 8, 2023
@syuilo
Copy link
Member

syuilo commented Apr 8, 2023

👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
2 participants