Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: condense acct #10753

Merged
merged 3 commits into from
May 4, 2023
Merged

feat: condense acct #10753

merged 3 commits into from
May 4, 2023

Conversation

acid-chicken
Copy link
Member

What

MkAcct が上位要素のサイズをはみ出す時縮小する

Why

#10749 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@acid-chicken acid-chicken self-assigned this May 2, 2023
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #10753 (aeed2e1) into develop (5349899) will decrease coverage by 0.01%.
The diff coverage is 77.41%.

@@             Coverage Diff             @@
##           develop   #10753      +/-   ##
===========================================
- Coverage    78.35%   78.34%   -0.01%     
===========================================
  Files          166      167       +1     
  Lines        20680    20740      +60     
  Branches       373      375       +2     
===========================================
+ Hits         16203    16249      +46     
- Misses        4477     4491      +14     
Impacted Files Coverage Δ
...frontend/src/components/global/MkCondensedLine.vue 75.00% <75.00%> (ø)
packages/frontend/src/components/global/MkAcct.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/index.ts 93.15% <100.00%> (+0.29%) ⬆️

@acid-chicken acid-chicken marked this pull request as ready for review May 2, 2023 17:34
@github-actions github-actions bot requested a review from syuilo May 2, 2023 17:34
@syuilo
Copy link
Member

syuilo commented May 3, 2023

ローカルで試した感じ挙動が不安定な感じが

@acid-chicken
Copy link
Member Author

ローカルで試した感じ挙動が不安定な感じが

こういうことかしら bf59fbb

@syuilo
Copy link
Member

syuilo commented May 4, 2023

おー動いた

@syuilo
Copy link
Member

syuilo commented May 4, 2023

パフォーマンスへの影響が気になるから実験的機能フラグで切り替えられるようにするかも

@syuilo syuilo merged commit 2cfed33 into develop May 4, 2023
@syuilo syuilo deleted the feat/MkCondensedLine branch May 4, 2023 23:16
@syuilo
Copy link
Member

syuilo commented May 4, 2023

👍🏻

sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
* feat: condense acct

* fix: watch parent element size

---------

Co-authored-by: syuilo <[email protected]>
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
* feat: condense acct

* fix: watch parent element size

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants