Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce Meilisearch #10755

Merged
merged 14 commits into from
May 4, 2023
Merged

feat: Introduce Meilisearch #10755

merged 14 commits into from
May 4, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented May 3, 2023

What

#9323

Why

より良い全文検索のため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Sorry, something went wrong.

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #10755 (d161d6a) into develop (8c70bbe) will decrease coverage by 17.42%.
The diff coverage is 41.70%.

❗ Current head d161d6a differs from pull request most recent head 597d749. Consider uploading reports for the commit 597d749 to get more accurate results

@@             Coverage Diff              @@
##           develop   #10755       +/-   ##
============================================
- Coverage    94.71%   77.29%   -17.42%     
============================================
  Files            2      900      +898     
  Lines          454    89579    +89125     
  Branches        59     6545     +6486     
============================================
+ Hits           430    69243    +68813     
- Misses          24    20336    +20312     
Impacted Files Coverage Δ
packages/backend/src/server/api/endpoints/meta.ts 75.14% <ø> (ø)
...s/backend/src/server/api/endpoints/notes/search.ts 81.17% <20.00%> (ø)
packages/backend/src/core/SearchService.ts 33.13% <33.13%> (ø)
packages/backend/src/GlobalModule.ts 96.63% <77.77%> (ø)
packages/backend/src/config.ts 97.40% <100.00%> (ø)
packages/backend/src/core/CoreModule.ts 100.00% <100.00%> (ø)
packages/backend/src/core/NoteCreateService.ts 86.99% <100.00%> (ø)
packages/backend/src/di-symbols.ts 100.00% <100.00%> (ø)

... and 890 files with indirect coverage changes

@u1-liquid
Copy link
Contributor

維持管理観点である程度規模のあるサーバーならelasticsearchの方が安定すると思うので消しちゃうのはよくないかも

meilisearchはスケールアウトができない、(現時点では)レプリケーションもサポートされてないなどプロダクションで動かすにはリスクあるように感じた

@syuilo
Copy link
Member Author

syuilo commented May 3, 2023

維持管理観点である程度規模のあるサーバーならelasticsearchの方が安定すると思うので消しちゃうのはよくないかも

meilisearchはスケールアウトができない、(現時点では)レプリケーションもサポートされてないなどプロダクションで動かすにはリスクあるように感じた

elasticsearchは既に消えてる(このPRで残ってたゴミを消した)

@syuilo syuilo marked this pull request as ready for review May 3, 2023 08:23
@github-actions github-actions bot requested a review from EbiseLutica May 3, 2023 08:23
@u1-liquid
Copy link
Contributor

u1-liquid commented May 3, 2023

設定ファイルの注釈としてアップデート時の注意点(と手順)のリンク貼っておいたほうがいいかも

https://www.meilisearch.com/docs/learn/update_and_migration/updating#updating-a-local-or-deployed-meilisearch-instance

あとできればsnapshotの設定例もいるかも

@EbiseLutica
Copy link
Contributor

レビューアサインされてるけど、meilisearchわからんな…。

@syuilo
Copy link
Member Author

syuilo commented May 3, 2023

#9323 (comment)

@syuilo syuilo closed this May 3, 2023
@syuilo syuilo reopened this May 3, 2023
@github-actions github-actions bot requested a review from rinsuki May 3, 2023 09:28
@syuilo
Copy link
Member Author

syuilo commented May 4, 2023

設定ファイルの注釈としてアップデート時の注意点(と手順)のリンク貼っておいたほうがいいかも

https://www.meilisearch.com/docs/learn/update_and_migration/updating#updating-a-local-or-deployed-meilisearch-instance

あとできればsnapshotの設定例もいるかも

書くとしたらMisskey Hubかも

@syuilo syuilo merged commit 5c08f2b into develop May 4, 2023
@syuilo syuilo deleted the meilisearch branch May 4, 2023 23:52
sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
* wip

* wip

* Update SearchService.ts

* Update SearchService.ts

* wip

* wip

* Update SearchService.ts

* Update CHANGELOG.md

* wip

* Update SearchService.ts

* Update docker-compose.yml.example
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
* wip

* wip

* Update SearchService.ts

* Update SearchService.ts

* wip

* wip

* Update SearchService.ts

* Update CHANGELOG.md

* wip

* Update SearchService.ts

* Update docker-compose.yml.example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants