Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiAuth同意画面では寄付Popupを表示しない #10779

Merged
merged 2 commits into from
May 6, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

Fix #10771

What

タイトル通り

/miauthから始まるページにアクセスした際には寄付ポップアップを表示しないように条件を追加)

Why

#10771

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 6, 2023
@github-actions github-actions bot requested review from rinsuki and syuilo May 6, 2023 13:11
@syuilo syuilo merged commit 39becdb into misskey-dev:develop May 6, 2023
@syuilo
Copy link
Member

syuilo commented May 6, 2023

🙏

@tamaina
Copy link
Contributor

tamaina commented May 6, 2023

(そもそも新規デバイスログイン時に寄付ダイアログが出るのが鬱陶しいけどまあ仕方ないか)

@kakkokari-gtyih
Copy link
Contributor Author

(そもそも新規デバイスログイン時に寄付ダイアログが出るのが鬱陶しいけどまあ仕方ないか)

寄付ダイアログ関連の情報をレジストリに持たせるといいかも…?

@kakkokari-gtyih kakkokari-gtyih deleted the niauth-donation-diag branch May 6, 2023 13:15
@yamanetaisei
Copy link

#10771 を起票した者です。

迅速なご対応ありがとうございました !
デプロイを楽しみにしています 😆

@kakkokari-gtyih @syuilo

sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
4 participants