Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check for PRs #10804

Merged
merged 5 commits into from
May 8, 2023
Merged

ci: check for PRs #10804

merged 5 commits into from
May 8, 2023

Conversation

acid-chicken
Copy link
Member

What

Chromatic を PR 全体の差分で走らせる

Why

push ごとの判定だと turbosnap の省略に巻き込まれるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot requested a review from rinsuki May 8, 2023 14:54
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #10804 (1696927) into develop (34e958c) will increase coverage by 1.15%.
The diff coverage is n/a.

❗ Current head 1696927 differs from pull request most recent head 464e773. Consider uploading reports for the commit 464e773 to get more accurate results

@@             Coverage Diff             @@
##           develop   #10804      +/-   ##
===========================================
+ Coverage    77.30%   78.45%   +1.15%     
===========================================
  Files          905      169     -736     
  Lines        90320    21150   -69170     
  Branches      6613      376    -6237     
===========================================
- Hits         69820    16594   -53226     
+ Misses       20500     4556   -15944     

see 740 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Chromatic will skip testing but you may still have to review the changes on Chromatic.

@acid-chicken acid-chicken merged commit 3510768 into develop May 8, 2023
@acid-chicken acid-chicken deleted the chromatic/pr branch May 8, 2023 15:14
sasagar pushed a commit to sasagar/misskey that referenced this pull request May 9, 2023
* ci: check for PRs

* ci: run all PRs

* ci: fix syntax error

* ci: comment on PRs only

* ci: use pull_request_target
na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
* ci: check for PRs

* ci: run all PRs

* ci: fix syntax error

* ci: comment on PRs only

* ci: use pull_request_target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant