Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): "メッセージを送信" の初期テキストを修正する #11721

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

Hexirp
Copy link
Contributor

@Hexirp Hexirp commented Aug 14, 2023

What

他のサーバーのユーザーへ "メッセージを送信" した時の初期テキストのメンションにサーバーを指定する部分が欠落していたのを修正しました。

Why

Fix #11716

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Hexirp added 2 commits August 14, 2023 21:17
あるサーバー A にいるとする。他のサーバー B のユーザー X へ
「メッセージを送信」しようとしたとする。その時に出てくる投稿
フォームには X へのメンションが最初から入っている。

しかし、そのメンションには B の情報が入っておらず、 A の
同名ユーザー X へのメンションとなってしまっている。

See misskey-dev#11716
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #11721 (89fb8ac) into develop (ba16abb) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #11721      +/-   ##
===========================================
+ Coverage    78.65%   78.69%   +0.03%     
===========================================
  Files          922      924       +2     
  Lines        97367    97537     +170     
  Branches      7742     7743       +1     
===========================================
+ Hits         76586    76757     +171     
+ Misses       20781    20780       -1     
Files Changed Coverage Δ
packages/frontend/src/scripts/get-user-menu.ts 5.53% <0.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

@syuilo syuilo merged commit bf6158c into misskey-dev:develop Aug 20, 2023
@syuilo
Copy link
Member

syuilo commented Aug 20, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
2 participants