Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: VSCodeにて保存時にeslintでauto fixさせるように #12693

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

ikasoba
Copy link
Contributor

@ikasoba ikasoba commented Dec 16, 2023

What

  • 保存時にeslintでauto fixさせてみるようにしました。
  • また、ユーザー設定のフォーマッターと衝突しないようワークスペースの設定を変更しました。

Why

  • PR作成時などに便利なため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (742da2f) 79.74% compared to head (ab026be) 79.64%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12693      +/-   ##
===========================================
- Coverage    79.74%   79.64%   -0.11%     
===========================================
  Files          955      954       -1     
  Lines       107697   107650      -47     
  Branches      8378     8351      -27     
===========================================
- Hits         85887    85736     -151     
- Misses       21810    21914     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 24261f6 into misskey-dev:develop Dec 18, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 18, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants