Complete unicode emoji after last colon #13384
Open
+155
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13384 +/- ##
============================================
- Coverage 38.78% 18.86% -19.92%
============================================
Files 1601 762 -839
Lines 203886 110734 -93152
Branches 4025 1231 -2794
============================================
- Hits 79072 20893 -58179
+ Misses 124178 89256 -34922
+ Partials 636 585 -51 ☔ View full report in Codecov by Sentry. |
anatawa12
force-pushed
the
complete-emoji-after-last-colon
branch
from
d207f0c to
94069e7
Compare
u1-liquid
added a commit
to MisskeyIO/misskey
that referenced
this pull request
Mar 15, 2024
Co-authored-by: anatawa12 <[email protected]>
u1-liquid
added a commit
to MisskeyIO/misskey
that referenced
this pull request
Mar 15, 2024
Co-authored-by: anatawa12 <[email protected]>
|
こういう事象がおこっているらしい
|
|
用途的に完全一致で問題ないから完全一致のみ表示するようにするか |
した |
anatawa12
force-pushed
the
complete-emoji-after-last-colon
branch
from
188e2a3 to
47c4a6e
Compare
|
lintはaddし忘れだった(add後に修正してたの忘れてた)すみませｎ |
|
frontend e2eは develop もおちてそう？ https://github.com/misskey-dev/misskey/actions/runs/8407815099/job/23023188423 |
|
Cypress → #13605 ? |
u1-liquid
added a commit
to MisskeyIO/misskey
that referenced
this pull request
Mar 30, 2024
cheery-picked from anatawa12/misskey@47c4a6e * fix code quality issues Co-authored-by: anatawa12 <[email protected]>
u1-liquid
added a commit
to MisskeyIO/misskey
that referenced
this pull request
Mar 31, 2024
…586) cheery-picked from anatawa12/misskey@47c4a6e * fix code quality issues Co-authored-by: anatawa12 <[email protected]>
|
changelogついかしてなかったので追加しました |
|
conflict resolved |
5 tasks
|
conflict解消 |
anatawa12
force-pushed
the
complete-emoji-after-last-colon
branch
from
6254c15 to
1e6faf7
Compare
|
conflict resolved (again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix #12662
Why
Issue参照。
githubやdiscordなどで
:+1:の形式に慣れている人だと息をするように最後の:まで入力してしまい、これが unicode emoji に変換できないのがストレスになるため。Additional info (optional)
使いまわしたのでfuzzy searchになってますが、完全一致だけでもいいとは思っています。#13384 (comment) 不都合があったっぽいので完全一致にしました
Checklist