fix(backend): リバーシの設定変更が反映されないのを修正 #14404
Merged
+47
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
|
このPRによるapi.jsonの差分 差分はこちら |
kakkokari-gtyih
commented
Aug 13, 2024
Comment on lines
+407
to
+424
| public isValidReversiUpdateValue<K extends typeof reversiUpdateKeys[number]>(key: K, value: unknown): value is MiReversiGame[K] { | ||
| switch (key) { | ||
| case 'map': | ||
| return Array.isArray(value) && value.every(row => typeof row === 'string'); | ||
| case 'bw': | ||
| return typeof value === 'string' && ['random', '1', '2'].includes(value); | ||
| case 'isLlotheo': | ||
| return typeof value === 'boolean'; | ||
| case 'canPutEverywhere': | ||
| return typeof value === 'boolean'; | ||
| case 'loopedBoard': | ||
| return typeof value === 'boolean'; | ||
| case 'timeLimitForEachTurn': | ||
| return typeof value === 'number' && value >= 0; | ||
| default: | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
ちゃんとした値の定義が存在しなかったので、必要な値をはじいていないかをしゅいろさんに確認してもらう必要あり
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14404 +/- ##
===========================================
+ Coverage 39.91% 41.74% +1.83%
===========================================
Files 1545 1549 +4
Lines 190505 196580 +6075
Branches 2654 3589 +935
===========================================
+ Hits 76046 82070 +6024
- Misses 113898 113949 +51
Partials 561 561 ☔ View full report in Codecov by Sentry. |
|
|
|
javascriptでは |
|
いれた |
|
🙏🏻 |
KisaragiEffective
added a commit
to ksrgtech/misskey
that referenced
this pull request
Aug 16, 2024
This reverts commit a8810af.
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Aug 19, 2024
* fix(backend): リバーシの設定変更が反映されないのを修正 * Update Changelog * add bindthis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #14397
Additional info (optional)
Checklist