feat: エクスポート完了時に通知を発行するように #14484
Merged
feat: エクスポート完了時に通知を発行するように #14484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
|
通知にペイロードが乗らないの謎 |
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -46020,6 +46020,7 @@
"followRequestAccepted",
"roleAssigned",
"achievementEarned",
+ "exportCompleted",
"app",
"test",
"pollVote",
@@ -46044,6 +46045,7 @@
"followRequestAccepted",
"roleAssigned",
"achievementEarned",
+ "exportCompleted",
"app",
"test",
"pollVote",
@@ -46259,6 +46261,7 @@
"followRequestAccepted",
"roleAssigned",
"achievementEarned",
+ "exportCompleted",
"app",
"test",
"reaction:grouped",
@@ -46285,6 +46288,7 @@
"followRequestAccepted",
"roleAssigned",
"achievementEarned",
+ "exportCompleted",
"app",
"test",
"reaction:grouped",
@@ -78999,6 +79003,50 @@
]
},
{
+ "type": "object",
+ "properties": {
+ "id": {
+ "type": "string",
+ "format": "id"
+ },
+ "createdAt": {
+ "type": "string",
+ "format": "date-time"
+ },
+ "type": {
+ "type": "string",
+ "enum": [
+ "exportCompleted"
+ ]
+ },
+ "exportedEntity": {
+ "type": "string",
+ "enum": [
+ "antenna",
+ "blocking",
+ "clip",
+ "customEmoji",
+ "favorite",
+ "following",
+ "muting",
+ "note",
+ "userList"
+ ]
+ },
+ "fileId": {
+ "type": "string",
+ "format": "id"
+ }
+ },
+ "required": [
+ "id",
+ "createdAt",
+ "type",
+ "exportedEntity",
+ "fileId"
+ ]
+ },
+ {
"type": "object",
"properties": {
"id": { |
ここに追記する必要がありそうです misskey/packages/backend/src/core/entities/NotificationEntityService.ts Lines 149 to 170 in 8be624a |
zyoshoka
reviewed
Sep 1, 2024
|
いけた🙏 |
syuilo
reviewed
Sep 1, 2024
| @@ -2436,6 +2438,8 @@ _notification: | |||
| followRequestAccepted: "フォローが受理された" | |||
| roleAssigned: "ロールが付与された" | |||
| achievementEarned: "実績の獲得" | |||
| exportCompleted: "エクスポートが完了した" | |||
| test: "通知のテスト" | |||
There was a problem hiding this comment.
通知受信設定のやつ（ただしtestもexportCompletedも設定不可なので実際には表示されない）
|
コンフリクト解消 |
|
コンフリクト解消 |
syuilo
reviewed
Sep 15, 2024
packages/backend/src/types.ts
Outdated
Comment on lines
56
to
59
| export const exportableEntities = ['antenna', 'blocking', 'clip', 'customEmoji', 'favorite', 'following', 'muting', 'note', 'userList'] as const; | ||
|
|
||
| export const importableEntities = ['antenna', 'blocking', 'customEmoji', 'following', 'muting', 'userList'] as const; | ||
|
|
There was a problem hiding this comment.
Suggested change
| export const exportableEntities = ['antenna', 'blocking', 'clip', 'customEmoji', 'favorite', 'following', 'muting', 'note', 'userList'] as const; | |
| export const importableEntities = ['antenna', 'blocking', 'customEmoji', 'following', 'muting', 'userList'] as const; | |
| export const exportableEntityKinds = ['antenna', 'blocking', 'clip', 'customEmoji', 'favorite', 'following', 'muting', 'note', 'userList'] as const; | |
| export const importableEntitiyKinds = ['antenna', 'blocking', 'customEmoji', 'following', 'muting', 'userList'] as const; | |
とか…？ (何なのかわからない、というのは元からどうしようもなさそう)
There was a problem hiding this comment.
userExportableEntities / userImportableEntites とか？
There was a problem hiding this comment.
Suggested change
| export const exportableEntities = ['antenna', 'blocking', 'clip', 'customEmoji', 'favorite', 'following', 'muting', 'note', 'userList'] as const; | |
| export const importableEntities = ['antenna', 'blocking', 'customEmoji', 'following', 'muting', 'userList'] as const; | |
| // ユーザーがエクスポートできるエンティティ | |
| export const userExportableEntities = ['antenna', 'blocking', 'clip', 'customEmoji', 'favorite', 'following', 'muting', 'note', 'userList'] as const; | |
| // ユーザーがインポートできるエンティティ | |
| export const userImportableEntities = ['antenna', 'blocking', 'customEmoji', 'following', 'muting', 'userList'] as const; | |
There was a problem hiding this comment.
エンティティというのが何を指しているのか明確にしたいかも
良い感じの表現を募集中
There was a problem hiding this comment.
- この値は何に使われるのを想定しているのか？
- 既存のデータベースのテーブル名などと一致させる必要があるのか？それとも自由に決めていいものなのか？
|
ping |
|
マージするか |
|
👍🏻 |
|
ちょっと気になった |
MkNotificationとかの問題そう |
HotoRas
pushed a commit
to HotoRas/misskey-neko
that referenced
this pull request
Sep 27, 2024
* feat: エクスポート完了時に通知を発行するように * Update Changelog * entitity -> entity * fix: ペイロードを含むように * fix icon * exportableEntities -> userExportableEntities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
#14456 が一部修正される
Additional info (optional)
#14484 (comment) をなんとかする必要があるいけたChecklist