Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザーミュートにメンションが考慮されるように #14995

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

Sayamame-beans
Copy link
Member

@Sayamame-beans Sayamame-beans commented Nov 18, 2024

What

  • Fix: ユーザーミュートにおいて、ノート内のメンションが考慮されていなかった問題を修正
    • これにより、第三者から自分に対するノートを意図せず取り逃してしまう可能性があったため、通知欄ではメンションを考慮しないままになっています

Why

fix: #2690

Additional info (optional)

現在未テストです 多分動きます

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 18, 2024
@Sayamame-beans Sayamame-beans marked this pull request as ready for review November 18, 2024 14:19
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 38.69%. Comparing base (0c634c9) to head (805cb7c).

Files with missing lines Patch % Lines
packages/backend/src/core/QueryService.ts 5.88% 16 Missing ⚠️
packages/backend/src/misc/is-user-related.ts 0.00% 4 Missing ⚠️
...backend/src/server/api/endpoints/notes/mentions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14995      +/-   ##
===========================================
- Coverage    38.71%   38.69%   -0.03%     
===========================================
  Files         1603     1603              
  Lines       204303   204323      +20     
  Branches      4028     4010      -18     
===========================================
- Hits         79104    79068      -36     
- Misses      124561   124617      +56     
  Partials       638      638              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@Sayamame-beans
Copy link
Member Author

何か手元でテストしないとヤバそうな雰囲気がするのでdraftに戻します

@Sayamame-beans Sayamame-beans marked this pull request as draft November 18, 2024 14:39
@Sayamame-beans Sayamame-beans marked this pull request as ready for review November 19, 2024 13:49
@Sayamame-beans
Copy link
Member Author

Sayamame-beans commented Nov 19, 2024

追記: 親投稿や引用元投稿にメンションがあって、その子や引用にはメンションがないようなケースに対しては現状判定出来ていません
(isUserRelatedの方にはあるかもしれませんが、generateMutedUserQueryの方にはメンションの情報が無さそうかな、と思っています…実は両方あったりしますかね?)
加えて、自身が付けたメンションによってもノートがミュートされてしまっており、悩ましいところです(#15002 の返答に応じて対応したい気持ちがあります。)

あと、テストがコケている理由がまだ理解しきれていません

@Sayamame-beans
Copy link
Member Author

(何が原因でテストがコケているんでしょうこれ…)

@samunohito
Copy link
Member

e2eだけで見るとクリップまわりっぽいですが…

@Sayamame-beans
Copy link
Member Author

調査中(確かにクリップが壊れていました、なぜ…)

@Sayamame-beans
Copy link
Member Author

TLだとFTTが効いてて気付かなかっただけで普通に壊れてました…

@Sayamame-beans Sayamame-beans marked this pull request as draft November 21, 2024 12:33
@Sayamame-beans Sayamame-beans marked this pull request as ready for review November 21, 2024 13:19
@Sayamame-beans
Copy link
Member Author

直しました(すみません)

@Sayamame-beans
Copy link
Member Author

conflict解消

@Sayamame-beans
Copy link
Member Author

resolved conflict

@Sayamame-beans
Copy link
Member Author

fixed ci failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
2 participants