Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: GitHub ActionsでのFFmpegインストールの失敗時リトライするように #15079

Merged

Conversation

kanarikanaru
Copy link
Contributor

What

  • backendのunitテストや連合テストで行われるffmepgインストールをリトライロジックを追加したものに書き換えた

Why

  • テスト実行時、頻度は低いもののffmepgインストールに失敗→テスト自体が失敗として扱われる
  • テストを通すために再度手動で実行するのが面倒

Additional info (optional)

  • 動作すること、この状態でunitテストを通過できることを確認済み

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.89%. Comparing base (3c81926) to head (17429af).
Report is 37 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15079       +/-   ##
============================================
+ Coverage    39.96%   62.89%   +22.93%     
============================================
  Files         1563      835      -728     
  Lines       197878    94006   -103872     
  Branches      3646     2669      -977     
============================================
- Hits         79080    59128    -19952     
+ Misses      118193    34827    -83366     
+ Partials       605       51      -554     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanarikanaru kanarikanaru changed the title Enhance: GitHub Actionsでのffmpegインストールの失敗時リトライするように Enhance: GitHub ActionsでのFFmpegインストールの失敗時リトライするように Nov 30, 2024
@syuilo syuilo merged commit 9ddf775 into misskey-dev:develop Jan 14, 2025
11 checks passed
@syuilo
Copy link
Member

syuilo commented Jan 14, 2025

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants