Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): pages/updateのnameの重複チェックはnameプロパティがある時のみ行うように #15104

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

What

かいてあるとおり

Why

Fix #15097

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.45%. Comparing base (d2e22f9) to head (e4f805a).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/backend/src/server/api/endpoints/pages/update.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15104      +/-   ##
===========================================
- Coverage    39.45%   39.45%   -0.01%     
===========================================
  Files         1566     1566              
  Lines       198811   198813       +2     
  Branches      3638     3635       -3     
===========================================
- Hits         78447    78436      -11     
- Misses      119793   119806      +13     
  Partials       571      571              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit da9e055 into misskey-dev:develop Jan 14, 2025
12 of 18 checks passed
Copy link

Thank you 🙏

Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Jan 14, 2025
…y-dev#15104)

* fix(backend): pagesのnameの重複チェックはnameプロパティがある時のみ行うように

* Update Changelog

---------

Co-authored-by: syuilo <[email protected]>
@kakkokari-gtyih kakkokari-gtyih deleted the fix-15097 branch January 14, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
2 participants