レプリケーション設定時におけるinsertOne()の挙動を調整 #15109
Open
+60
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samunohito
changed the title
|
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15109 +/- ##
============================================
+ Coverage 18.82% 38.67% +19.85%
============================================
Files 766 1605 +839
Lines 111400 204701 +93301
Branches 1234 3868 +2634
============================================
+ Hits 20966 79163 +58197
- Misses 89845 124930 +35085
- Partials 589 608 +19 ☔ View full report in Codecov by Sentry. |
samunohito
changed the title
|
open |
samunohito
commented
Dec 10, 2024
Comment on lines
+106
to
+107
| const opt = this.manager.connection.options as PostgresConnectionOptions; | ||
| if (opt.replication) { |
There was a problem hiding this comment.
configに設定したreplicationの値が巡り巡ってこの値に入っています。
レプリケーションが無効の時はnull（かundefinedかは忘れましたが）になっているので、else（＝今までの処理）に流れます。
| @@ -92,14 +103,31 @@ export const miRepository = { | |||
| return this.metadata.columns.filter(column => column.isSelect && !column.isVirtual).map(column => column.databaseName); | |||
| }, | |||
| async insertOne(entity, findOptions?) { | |||
| const opt = this.manager.connection.options as PostgresConnectionOptions; | |||
| if (opt.replication) { | |||
| const queryRunner = this.manager.connection.createQueryRunner('master'); | |||
There was a problem hiding this comment.
これによりmasterノードでクエリを実行してくれるrunnerが取れます。
5 tasks
5 tasks
# Conflicts: # CHANGELOG.md # packages/backend/src/postgres.ts
kakkokari-gtyih
modified the milestones:
[DO NOT MERGE THESE YET] v2025.3.1～,
v2025.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
※2024.12.0より後にしたい
What
各Repositoryが持つinsertOne()メソッドの挙動を少し変更します。
この対応により、insertOne()によるレコード挿入は必ずmasterノードで行うようになります。
Why
fix #10897
Additional info (optional)
Checklist