Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: 連合モードにあわせてフロントエンドを変化させるように #15112

Merged
merged 15 commits into from
Jan 14, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 10, 2024

What

  • metaに連合モードを公開するように
  • 連合モードに応じてフロントエンドを対応させるように(変えた部分ごとにコミットしているため、詳細はコミットメッセージを参照のこと)

Why

Fix #15111

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 4.37956% with 131 lines in your changes missing coverage. Please review.

Project coverage is 40.88%. Comparing base (7fbfc2e) to head (6a72e9c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/about.vue 0.00% 30 Missing ⚠️
packages/frontend/src/components/MkWidgets.vue 0.00% 15 Missing ⚠️
packages/frontend/src/pages/search.note.vue 0.00% 12 Missing ⚠️
packages/frontend/src/ui/_common_/common.ts 0.00% 12 Missing ⚠️
...ckages/frontend/src/components/MkInstanceStats.vue 0.00% 11 Missing ⚠️
packages/frontend/src/scripts/please-login.ts 10.00% 9 Missing ⚠️
packages/frontend/src/widgets/index.ts 0.00% 8 Missing ⚠️
...ges/frontend/src/components/MkUserSelectDialog.vue 0.00% 7 Missing ⚠️
packages/frontend/src/pages/settings/privacy.vue 0.00% 5 Missing ⚠️
...s/frontend/src/components/MkSignupDialog.rules.vue 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15112      +/-   ##
===========================================
+ Coverage    39.29%   40.88%   +1.59%     
===========================================
  Files         1564     1568       +4     
  Lines       198148   203998    +5850     
  Branches      3548     3582      +34     
===========================================
+ Hits         77855    83414    +5559     
- Misses      119688   119973     +285     
- Partials       605      611       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 10, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -82971,6 +82971,14 @@
           },
           "maxFileSize": {
             "type": "number"
+          },
+          "federation": {
+            "type": "string",
+            "enum": [
+              "all",
+              "specified",
+              "none"
+            ]
           }
         },
         "required": [
@@ -83024,7 +83032,8 @@
           "themeColor",
           "policies",
           "noteSearchableScope",
-          "maxFileSize"
+          "maxFileSize",
+          "federation"
         ]
       },
       "MetaDetailedOnly": {

Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review December 10, 2024 06:45
@mi-gh-maintainer mi-gh-maintainer bot merged commit 5445b02 into misskey-dev:develop Jan 14, 2025
35 of 36 checks passed
Copy link

Thank you 🙏

Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Jan 14, 2025
* enhance(backend): metaにfederation modeに関する情報を公開

* enhance(frontend): 登録画面の注意書きを追加

* enhance(frontend): aboutページ・サーバー情報

* enhance(frontend): サーバー統計

* enhance(frontend): みつけるページ

* enhance(frontend): 検索

* enhance(frontend): ユーザー選択

* enhance(frontend): 設定画面

* enhance(frontend): ウィジェット

* enhance(frontend): リモートで開くオプション

* Update Changelog

* enhance(frontend): ステータスバー

* i18n

---------

Co-authored-by: syuilo <[email protected]>
@kakkokari-gtyih kakkokari-gtyih deleted the enh-15111 branch January 14, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥high priority packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

連合モードがON以外の場合にフロントエンドを対応させる
2 participants