Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MiAuth認可画面で、認可処理に失敗した場合でもコールバックURLに遷移してしまう問題を修正 #15154

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

書いてあるとおり

Why

たぶんミス

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 19.31%. Comparing base (020882e) to head (dc001ba).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/miauth.vue 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15154       +/-   ##
============================================
- Coverage    38.90%   19.31%   -19.59%     
============================================
  Files         1563      728      -835     
  Lines       197893   103887    -94006     
  Branches      3333      991     -2342     
============================================
- Hits         76985    20066    -56919     
+ Misses      120297    83267    -37030     
+ Partials       611      554       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit 574034a into misskey-dev:develop Jan 4, 2025
1 of 2 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-miauth-callback branch January 4, 2025 06:08
Ruruke pushed a commit to Ruruke/rukey that referenced this pull request Jan 4, 2025
…ey-dev#15154)

* feat(MiAuth): アクセストークンの発行に失敗した場合コールバックに遷移しないようにする (MisskeyIO#831)

Cherry-picked from TeamNijimiss/misskey@8003596

Co-authored-by: nafu-at <[email protected]>

* Update Changelog

* Update Changelog

---------

Co-authored-by: あわわわとーにゅ <[email protected]>
Co-authored-by: nafu-at <[email protected]>
kanarikanaru added a commit to HanaMisskey/misskey that referenced this pull request Jan 7, 2025
* 2025 (misskey-dev#15203)

* enhance(frontend): ワードミュート・ハードワードミュートの説明を追加 (misskey-dev#15207)

* pg_bigmが利用できるよう、ノートの検索をILIKE演算子でなくLIKE演算子でLOWER()をかけたテキストに対して行うように (misskey-dev#15205)

* Use LIKE-LOWER instead of ILIKE, which pg_bigm doesn't support.

* changelog: Enhance: pg_bigmが利用できるよう、ノートの検索をILIKE演算子でなくLIKE演算子でLOWER()をかけたテキストに対して行うように

* fix(frontend/AiScript): Ui:C:selectの値が切り替わらない問題を修正 (misskey-dev#15184)

* fix(frontend/AiScript): Ui:C:selectの値が切り替わらない問題を修正

* Update Changelog

* fix(backend): アプリ作成方式で作成したトークンの権限を表示するように (misskey-dev#15177)

* fix(frontend): MiAuth認可画面で、認可処理に失敗した場合でもコールバックURLに遷移してしまう問題を修正 (misskey-dev#15154)

* feat(MiAuth): アクセストークンの発行に失敗した場合コールバックに遷移しないようにする (MisskeyIO#831)

Cherry-picked from TeamNijimiss/misskey@8003596

Co-authored-by: nafu-at <[email protected]>

* Update Changelog

* Update Changelog

---------

Co-authored-by: あわわわとーにゅ <[email protected]>
Co-authored-by: nafu-at <[email protected]>

* Chore: Docker内のDebianのバージョンを上げる(bookworm) (misskey-dev#15073)

* fix(frontend): ノート検索が使用できない場合でもチャンネルのノート検索欄がでていた問題を修正 (misskey-dev#15082)

* fix(frontend): ノート検索が使用できない場合でもチャンネルのノート検索欄がでていた問題を修正

* Update Changelog

---------

Co-authored-by: syuilo <[email protected]>

* enhance(frontend/aiscript): セーブ内容を削除できるMk:removeを追加 (misskey-dev#15158)

* enhance(frontend/aiscript): セーブ内容を削除できる`Mk:remove`を追加

* fix

* Update Changelog

* fix(frontend): ファイルの添付可能数を超えたらノートボタンを押せないように (misskey-dev#15126)

* fix(frontend): ファイルの添付可能数を超えたらノートボタンを押せないように

* Update Changelog

* Update MkPostForm.vue

* fix(frontend): アカウント一覧画面で、ユーザー情報の取得に失敗したアカウントが表示されない問題を修正 (misskey-dev#15183)

* fix(frontend): アカウント一覧画面で、ユーザー情報の取得に失敗したアカウントが表示されない問題を修正

* Update Changelog

* 🎨

* [ci skip] Update CHANGELOG.md (書き方を揃える)

---------

Co-authored-by: Yuba <[email protected]>
Co-authored-by: 4ster1sk <[email protected]>
Co-authored-by: あわわわとーにゅ <[email protected]>
Co-authored-by: nafu-at <[email protected]>
Co-authored-by: KanariKanaru <[email protected]>
Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants