Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/deps(frontend): shikiのdeprecated表現を修正 #15169

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 22, 2024

What

  • shikiのloadWasmを新しい表現に置き換え
  • aiscript-vscodeをv0.1.15にアップデート
    • 名前空間ブロックのハイライトに対応
    • テンプレートリテラル内の波括弧のエスケープが効いていない問題を修正
    • 関数の引数にテンプレート文字列を取るとハイライトされない問題を修正
    • 名前空間関数の引数にテンプレート文字列を取るとハイライトされない問題を修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review December 22, 2024 08:17
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 19.31%. Comparing base (3c81926) to head (82862e9).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/merge.ts 0.00% 4 Missing ⚠️
packages/frontend/src/scripts/code-highlighter.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15169       +/-   ##
============================================
- Coverage    39.96%   19.31%   -20.65%     
============================================
  Files         1563      728      -835     
  Lines       197878   103872    -94006     
  Branches      3646      991     -2655     
============================================
- Hits         79080    20066    -59014     
+ Misses      118193    83252    -34941     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft December 22, 2024 08:40
@kakkokari-gtyih
Copy link
Contributor Author

失敗してたのでdraft

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review December 22, 2024 10:18
@mi-gh-maintainer mi-gh-maintainer bot merged commit d60c307 into misskey-dev:develop Jan 11, 2025
22 of 23 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-shikijs-deprecated branch January 11, 2025 13:47
Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Jan 11, 2025
* fix(frontend): shikiのdeprecated表現を修正

* update aiscript-vscode

* ✌️

* fix

* remove unused imports

* bump aiscript-vscode to 0.1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

1 participant