fix: タイムアウトを起こすe2eテストのタイムアウト時間設定を延長 #15283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
|
このPRによるapi.jsonの差分 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15283 +/- ##
===========================================
+ Coverage 39.43% 40.46% +1.03%
===========================================
Files 1568 1568
Lines 199142 199142
Branches 3656 3955 +299
===========================================
+ Hits 78537 80592 +2055
+ Misses 120032 117977 -2055
Partials 573 573 ☔ View full report in Codecov by Sentry. |
|
これで治るとは思うけどなんでタイムアウト引っかかるようになったかは考えたいかも。substringしてからハイライトすると不正なSQLでパフォーマンスがガタ落ちするとか |
1 task
1 task
|
テストに時間がかかることの根本原因の排除じゃないのでPRとissueのリンクを外しました |
1 task
Ruruke
added a commit
to Ruruke/rukey
that referenced
this pull request
Jan 15, 2025
fruitriin
pushed a commit
to fruitriin/misskey
that referenced
this pull request
Jan 16, 2025
kakkokari-gtyih
pushed a commit
to HanaMisskey/misskey
that referenced
this pull request
Jan 16, 2025
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#15282 に記載の通り、時間がかかっているテストがタイムアウトを起こすので時間を5秒伸ばしました。
また、#15076 を見る限り前々から起こっているようですが…迷宮入りの気配が漂うため、暫定対処という位置づけです。
Why
#15282
#15076
※根本対処ではないのでfixとはしない
Additional info (optional)
Checklist