Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): メールアドレスの形式が正しくなければ以降の処理を行わないように #15320

Conversation

sakuhanight
Copy link
Contributor

What

メールアドレスバリデーションの追加

Why

予期しないメールアドレスの入力が可能だった

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 21, 2025
@sakuhanight
Copy link
Contributor Author

#15056 からバリデーションの追加だけもってきました

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.13%. Comparing base (e2a55e2) to head (ba52862).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/EmailService.ts 0.00% 7 Missing ⚠️
packages/backend/src/core/UtilityService.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15320       +/-   ##
============================================
+ Coverage    14.57%   42.13%   +27.55%     
============================================
  Files          770     1609      +839     
  Lines        68497   161803    +93306     
  Branches      1305     4087     +2782     
============================================
+ Hits          9982    68168    +58186     
- Misses       58086    93187    +35101     
- Partials       429      448       +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih changed the title Mod: バリデーションを追加 fix(backend): メールアドレスとしての形式が正しくなければ以降の処理を行わないように Jan 21, 2025
@kakkokari-gtyih kakkokari-gtyih changed the title fix(backend): メールアドレスとしての形式が正しくなければ以降の処理を行わないように fix(backend): メールアドレスの形式が正しくなければ以降の処理を行わないように Jan 21, 2025
@kakkokari-gtyih

This comment was marked as resolved.

@sakuhanight

This comment was marked as resolved.

@kakkokari-gtyih kakkokari-gtyih modified the milestones: v2025.2.0, v2025.2.1 Jan 28, 2025
notつけわすれ
Copy link
Member

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恐らく良いのではないでしょうか
changelogの追加はあっても良いかもしれません

@mi-gh-maintainer mi-gh-maintainer bot merged commit f3a4434 into misskey-dev:develop Feb 16, 2025
32 checks passed
Copy link

Thank you 🙏

harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 21, 2025
* Mod: バリデーションを追加

* 条件の修正

notつけわすれ

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

4 participants