Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey-js): api extractorの出力をLFに強制 #15369

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Fix #15359

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md 軽微なので必要なし
  • (If possible) Add tests

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.38%. Comparing base (a3d236c) to head (9365322).
Report is 569 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15369      +/-   ##
===========================================
- Coverage    41.74%   40.38%   -1.36%     
===========================================
  Files         1549     1607      +58     
  Lines       196555   210108   +13553     
  Branches      2767     4084    +1317     
===========================================
+ Hits         82055    84858    +2803     
- Misses      113939   124612   +10673     
- Partials       561      638      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Feb 1, 2025

@anatawa12 これで警告出なくなりそうかしら

@anatawa12
Copy link
Member

anatawa12 commented Feb 1, 2025

lf強制だとwinで警告出てくる気がします(autocrlfがgit attributesで無効になってないので) 誤りでした

osって設定にするのが良いっぽい

@anatawa12
Copy link
Member

あっごめんなさい git attributesでeol=lfなのでこっちで良さそうです

Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです

@mi-gh-maintainer mi-gh-maintainer bot merged commit 06f113b into misskey-dev:develop Feb 1, 2025
27 checks passed
Copy link

Thank you 🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-15359 branch February 1, 2025 05:48
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 5, 2025
* fix(misskey-js): api extractorの出力をLFに強制

* indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants