Skip to content

Commit

Permalink
configure: port remove unused arm_neon variable
Browse files Browse the repository at this point in the history 
Port c6cd460 from io.js.

Original commit message:

  Remove the configure check, the flag was dropped in V8 3.28.

  PR-URL: nodejs/node#559
  Reviewed-By: Fedor Indutny <[email protected]>
  • Loading branch information
@bnoordhuis
bnoordhuis authored and Julien Gilli committed Mar 30, 2015
1 parent 354f6fe commit c601adc
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions configure
View file
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,6 @@ def is_arch_armv6():
'__ARM_ARCH_6M__' in cc_macros_cache)


def is_arm_neon():
"""Check for ARM NEON support"""
return '__ARM_NEON__' in cc_macros()


def is_arm_hard_float_abi():
"""Check for hardfloat or softfloat eabi on ARM"""
# GCC versions 4.6 and above define __ARM_PCS or __ARM_PCS_VFP to specify
Expand Down Expand Up @@ -492,11 +487,9 @@ def configure_arm(o):

if is_arch_armv7():
o['variables']['arm_fpu'] = 'vfpv3'
o['variables']['arm_neon'] = int(is_arm_neon())
o['variables']['arm_version'] = '7'
else:
o['variables']['arm_fpu'] = 'vfpv2'
o['variables']['arm_neon'] = 0
o['variables']['arm_version'] = '6' if is_arch_armv6() else 'default'

This comment has been minimized.

Sign in to view

Copy link
@wilson0x4d

wilson0x4d May 20, 2015

@bnoordhuis @misterdjules Line 493 (as of commit c601adc), specifically, shows an if/else on the right-side of the assignment, probably meant to be on the next line and indented for readability so people aren't overlooking it in the future.

this is what i was referring to in my comment some time back when noting "there appears to be some extra code at the end of line 477" (which now line 493 after patches/merges since.) sorry for the late response, i'm pulled so many directions every day.

This comment has been minimized.

Sign in to view

Copy link
@misterdjules

misterdjules May 20, 2015

Owner

@wilson0x4d I'm not familiar with Python, but I think that this if expression evaluates to '6' or 'default depending on the return value of is_arch_armv6(), and thus is intended to be written that way. I haven't looked at the commits history though.

o['variables']['arm_thumb'] = 0 # -marm
Expand Down

0 comments on commit c601adc

Please sign in to comment.