Fix #1357 map: broken when used without config object

mistic100 · Jul 8, 2024 · 7087488 · 7087488
1 parent 84c43d6
commit 7087488
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/build/select-packages.mjs b/build/select-packages.mjs
@@ -22,7 +22,6 @@ prompt([
             { value: 'core', checked: true },
             ...packages,
         ],
-        pageSize: 100,
     }
 ])
     .then((answers) => {

diff --git a/packages/core/src/utils/psv.ts b/packages/core/src/utils/psv.ts
@@ -398,10 +398,6 @@ export function getConfigParser<T extends Record<string, any>, U extends T = T>(
     parsers?: ConfigParsers<T, U>
 ): ConfigParser<T, U> {
     const parser = function (userConfig: T): U {
-        if (!userConfig) {
-            return clone(defaults);
-        }
-
         const rawConfig: U = clone({
             ...defaults,
             ...userConfig,

diff --git a/packages/map-plugin/src/MapPlugin.ts b/packages/map-plugin/src/MapPlugin.ts
@@ -49,7 +49,7 @@ const getConfig = utils.getConfigParser<MapPluginConfig, ParsedMapPluginConfig>(
             return utils.cleanCssPosition(position, { allowCenter: false, cssOrder: true }) || defValue;
         },
         rotation: (rotation) => utils.parseAngle(rotation),
-        coneColor: (coneColor) => (coneColor ? new Color(coneColor).getStyle() : null),
+        coneColor: (coneColor) => (coneColor ? new Color(coneColor).getStyle() : null), // must be in rgb format
         defaultZoom: (defaultZoom) => Math.log(defaultZoom / 100),
         maxZoom: (maxZoom) => Math.log(maxZoom / 100),
         minZoom: (minZoom) => Math.log(minZoom / 100),