Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equirectangular Tile preview bad rendering - A black line is visible on the joint point until the tiles are loaded #1214

Closed
Elius94 opened this issue Jan 23, 2024 · 2 comments
Labels
Milestone

Comments

@Elius94
Copy link

Elius94 commented Jan 23, 2024

Describe the bug

Hi Damien :)

I've found this issue in Equirectangular tile adapter.
It's present also in your official example.

The low quality preview of the pano is not connected right, if you see on the joint point (where the left and right side of the equirectangular picture are touching) there is a black line.
It seems an approximation issue of the width but I don't know.

image

Online demo URL

https://photo-sphere-viewer.js.org/guide/adapters/equirectangular-tiles.html#example

Photo Sphere Viewer version

5.6.0

Plugins loaded

EquirectangularTilesAdapter

OS & browser

Windows, Chrome

Additional context

No response

@Elius94 Elius94 added the bug label Jan 23, 2024
@mistic100
Copy link
Owner

mistic100 commented Jan 23, 2024

This is because of the blur effect. There is no solution, the canvas blur uses the surroundng pixels even if they are outside the canvas bounds (and they are black).

@mistic100 mistic100 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@mistic100 mistic100 added this to the 5.6.1 milestone Jan 25, 2024
Copy link

github-actions bot commented Feb 4, 2024

This feature/bug fix has been released in version 5.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants