v0.1.12: Support for backpack plugin integration & Fix several bugs #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HollowMan6
changed the title
HollowMan6
force-pushed
the
main
branch
2 times, most recently
from
a9e78d5 to
9a73da6
Compare
|
Let's wait for the adaptation to Blockly 11 to be completed (#39) before we land this PR. |
|
@HollowMan6 Sure thing. |
|
@ewpatton Let's merge this and release a new version (v0.1.12). This can be our last stable version for Blockly v10. I suddenly became aware that we will have significant breaking changes for Blockly v11 (#39), so I guess it will be better to raise the minor version number to v0.2.x or the major version number to v1.0.x since I can't guarantee that it will still be as stable as the old ones.
I will then open a separate PR for this. |
ewpatton
reviewed
Feb 27, 2024
Resolves mit-cml#42 Related to google/blockly@0b344e7 Signed-off-by: Songlin Jiang <[email protected]>
Cannot read properties of undefined (reading 'size')
TypeError: Cannot read properties of undefined (reading 'size')
at Object.preconditionFn (webpack-internal:///./src/multiselect_contextmenu.js:67:27)
Signed-off-by: Songlin Jiang <[email protected]>
Resolves mit-cml#37 Signed-off-by: Songlin Jiang <[email protected]>
Signed-off-by: Songlin Jiang <[email protected]>
Signed-off-by: Songlin Jiang <[email protected]>
Require blockly version to be 10.2.0-11 (as of mit-cml#39) Signed-off-by: Songlin Jiang <[email protected]>
…kpack We must listen events of all workspaces, not only the binded one, to cover all possible selection changes Signed-off-by: Songlin Jiang <[email protected]>
Resolve mit-cml#40 Signed-off-by: Songlin Jiang <[email protected]>
ewpatton
approved these changes
Feb 27, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right-click on a block in the backpack causes the following errors:
Resolves Add Backpack plugin support #37