Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DebugPauseDefault refactor to use bufio.Reader #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DebugPauseDefault refactor to use bufio.Reader #8

wants to merge 1 commit into from

Conversation

dacamp
Copy link

@dacamp dacamp commented Oct 22, 2016 •
edited
Loading

@dacamp dacamp mentioned this pull request Oct 22, 2016
Closed
dacamp
dacamp commented Dec 16, 2016
View reviewed changes
debug_runner_test.go
Steps: []Step{
&TestStepAcc{Data: "a"},
},
PauseFn: func(DebugLocation, string, StateBag) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using PauseFn is really the only useful change I made to this test. If the timing logs are clutter, let me know and I'll remove them.

@mwhooker
Copy link
Contributor

needs a quick rebase after a recent change

@dacamp
Fixes hashicorp/packer#4029
e6fe062 
- use PauseFn where possible during testing
@dacamp
Copy link
Author

dacamp commented Mar 16, 2017

There we go. It's a clean rebase, dunno why it was so eager to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacamp @mwhooker