implementing #160 #203

mattimatti · 2018-06-20T20:51:48Z

No description provided.

Temikus · 2018-06-24T22:31:54Z

Alright, fog got released, so I'll aim to release this by EOD Wednesday AEST. (probably much sooner) Need to write some tests for this and run the integration suite over.

Temikus

You forgot a default setting in: lib/vagrant-google/config.rb

        # internal_ip defaults to nil
        @internal_ip = nil if @internal_ip == UNSET_VALUE

, without it machine would receive Object as config.

Temikus · 2018-06-25T03:01:28Z

lib/vagrant-google/action/run_instance.rb

@@ -113,11 +115,21 @@ def call(env) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
            network = "global/networks/default"
          end

+


This whole block should not be necessary as we've implemented the change in fog-google

Temikus · 2018-06-25T03:04:20Z

If you need any help - just let me know! I'll be happy to :)

Temikus · 2018-06-25T03:05:37Z

Right now the acceptance tests are failing:

$ bundle exec rake acceptance:smoke
 1) provider/google/provisioner/shell it should behave like provider/provisioner/shell provisions with the shell script
     Failure/Error: assert_execute("vagrant", "up", "--provider=#{provider}")
       expected command to exit with 0 but got exit code: 1

       stdout: You appear to be running Vagrant outside of the official installers.
       Note that the installers are what ensure that Vagrant has all required
       dependencies, and Vagrant assumes that these dependencies exist. By
       running outside of the installer environment, Vagrant may not function
       properly. To remove this warning, install Vagrant using one of the
       official packages from vagrantup.com.
       Bringing machine 'default' up with 'google' provider...
       ==> default: Launching an instance with the following settings...
       ==> default:  -- Name:            i-2018062511-cab04630
       ==> default:  -- Project:         REDACTED
       ==> default:  -- Type:            n1-standard-1
       ==> default:  -- Disk type:       pd-standard
       ==> default:  -- Disk size:       10 GB
       ==> default:  -- Disk name:
       ==> default:  -- Image:
       ==> default:  -- Image family:    debian-9
       ==> default:  -- Instance Group:
       ==> default:  -- Zone:            us-central1-f
       ==> default:  -- Network:         default
       ==> default:  -- Network Project: REDACTED
       ==> default:  -- Metadata:        '{}'
       ==> default:  -- Labels:          '{}'
       ==> default:  -- Network tags:    '[]'
       ==> default:  -- IP Forward:
       ==> default:  -- Use private IP:  false
       ==> default:  -- External IP:
       ==> default:  -- Internal IP:     #<Object:0x00007fcd4d480720>
       ==> default:  -- Preemptible:     false
       ==> default:  -- Auto Restart:    true
       ==> default:  -- On Maintenance:  MIGRATE
       ==> default:  -- Autodelete Disk: true


       stderr: /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:218:in `check_status': invalid: Invalid value for field 'resource.networkInterfaces[0].networkIP': '#<Object:0x00007fcd4d480720>'. Requested internal IP is not a single IP. (Google::Apis::ClientError)
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/api_command.rb:116:in `check_status'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:183:in `process_response'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:299:in `execute_once'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:104:in `block (2 levels) in execute'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `times'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:101:in `block in execute'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:61:in `block in retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `times'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/retriable-3.1.2/lib/retriable.rb:56:in `retriable'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/http_command.rb:93:in `execute'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/lib/google/apis/core/base_service.rb:360:in `execute_or_queue_command'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/google-api-client-0.23.0/generated/google/apis/compute_v1/service.rb:6877:in `insert_instance'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/fog-google-1.6.0/lib/fog/compute/google/requests/insert_server.rb:111:in `insert_server'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/fog-google-1.6.0/lib/fog/compute/google/models/server.rb:485:in `save'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/fog-core-2.1.0/lib/fog/core/collection.rb:50:in `create'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/run_instance.rb:196:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/warn_ssh_keys.rb:28:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/warn_networks.rb:28:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/synced_folders.rb:87:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/provision.rb:80:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:95:in `block in finalize_action'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builder.rb:116:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `block in run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/util/busy.rb:19:in `busy'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/call.rb:53:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/Dropbox/Code/vagrant-google/lib/vagrant-google/action/connect_google.rb:44:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/box_check_outdated.rb:36:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/config_validate.rb:25:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builtin/handle_box.rb:56:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/warden.rb:34:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/builder.rb:116:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `block in run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/util/busy.rb:19:in `busy'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/action/runner.rb:66:in `run'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:239:in `action_raw'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:208:in `block in action'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/environment.rb:598:in `lock'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:194:in `call'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/machine.rb:194:in `action'
       	from /Users/temikus/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/bundler/gems/vagrant-dbba41a7ec3d/lib/vagrant/batch_action.rb:82:in `block (2 levels) in run'

Temikus · 2018-06-25T03:05:50Z

@mattimatti PTAL

Temikus · 2023-06-21T23:41:05Z

Closing this - please reopen if there's interest.

mattimatti added 2 commits June 20, 2018 18:50

Implemented private ips

275018e

fix mispelled var

6f61afc

mattimatti mentioned this pull request Jun 20, 2018

Added option for network ip fog/fog-google#361

Merged

Temikus requested changes Jun 25, 2018

View reviewed changes

Temikus closed this Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implementing #160 #203

implementing #160 #203

mattimatti commented Jun 20, 2018

Temikus commented Jun 24, 2018 •

edited

Loading

Temikus left a comment

Temikus Jun 25, 2018

Temikus commented Jun 25, 2018

Temikus commented Jun 25, 2018 •

edited

Loading

Temikus commented Jun 25, 2018

Temikus commented Jun 21, 2023

		@@ -113,11 +115,21 @@ def call(env) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
		network = "global/networks/default"
		end

implementing #160 #203

implementing #160 #203

Conversation

mattimatti commented Jun 20, 2018

Temikus commented Jun 24, 2018 • edited Loading

Temikus left a comment

Choose a reason for hiding this comment

Temikus Jun 25, 2018

Choose a reason for hiding this comment

Temikus commented Jun 25, 2018

Temikus commented Jun 25, 2018 • edited Loading

Temikus commented Jun 25, 2018

Temikus commented Jun 21, 2023

Temikus commented Jun 24, 2018 •

edited

Loading

Temikus commented Jun 25, 2018 •

edited

Loading