Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Confirm Rackspace server destruction. #116

Merged
merged 1 commit into from
Jul 24, 2014

Conversation

dkinzer
Copy link
Contributor

@dkinzer dkinzer commented Jul 24, 2014

This pull request implements a fix for #114

@maxlinc
Copy link
Contributor

maxlinc commented Jul 24, 2014

Wow... I got so used to typing "vagrant destroy -f" I never even noticed the -f didn't matter.

@smashwilson LGTM. Should be backwards compatible all the way back to Vagrant 1.2.2.

This pull request implements a fix for
mitchellh#114
@smashwilson
Copy link
Collaborator

@smashwilson LGTM. Should be backwards compatible all the way back to Vagrant 1.2.2.

Good enough for me!

smashwilson added a commit that referenced this pull request Jul 24, 2014
Confirm Rackspace server destruction.
@smashwilson smashwilson merged commit 5561c1a into mitchellh:master Jul 24, 2014
@dkinzer
Copy link
Contributor Author

dkinzer commented Jul 24, 2014

@maxlinc yeah, I was rather surprised too, and completely caught off guard.

I had set up a multi environment Vagrantfile and I needed to shed some VM weight off. I was relying on the confirmation to skip stuff I actually wanted to keep around and then the Rackspace stuff just disappeared without any confirmation. Ugh.

Fortunately it wasn't too much of a hassle to spin up the server again an get it provisioned, but I still...

@dkinzer
Copy link
Contributor Author

dkinzer commented Jul 24, 2014

@smashwilson I noticed that this was asking but not actually skipping so UI forced pushed "fix" but it's wrong ... I need to redo ... sorry, thought I had time to fix it before anyone would merge it.

@dkinzer
Copy link
Contributor Author

dkinzer commented Jul 24, 2014

I.e I forgot to require

uninitialized constant VagrantPlugins::Rackspace::Action::MessageWillNotDestroy

@dkinzer dkinzer deleted the confirm-before-destroy branch July 24, 2014 19:18
dkinzer pushed a commit to dkinzer/vagrant-rackspace that referenced this pull request Jul 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants