Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS resolver: add getaddrinfo fallback, fix test duration #7122

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

mhils
Copy link
Member

@mhils mhils commented Aug 20, 2024

Description

Fixes #7116
Fixes #7092
Fixes #7074
Obsoletes #7115

Depends on mitmproxy/mitmproxy_rs#169 (and a mitmproxy_rs release)

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

@mhils mhils requested a review from errorxyz August 20, 2024 14:34
Copy link
Contributor

@errorxyz errorxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great to see the ugly test cases now being cleaner :)

mitmproxy/addons/dns_resolver.py Outdated Show resolved Hide resolved
mitmproxy/addons/dns_resolver.py Show resolved Hide resolved
@mhils mhils enabled auto-merge (squash) August 28, 2024 13:32
@mhils mhils disabled auto-merge August 28, 2024 14:08
@mhils mhils requested a review from errorxyz August 28, 2024 14:55
Copy link
Contributor

@errorxyz errorxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@errorxyz errorxyz merged commit 343ad7a into mitmproxy:main Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants