Fix coupon apply button bug #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisecapella
force-pushed
the
gs/coupon_update
branch
from
3c0d164 to
50b0feb
Compare
noisecapella
force-pushed
the
gs/coupon_update
branch
from
50b0feb to
5e4f913
Compare
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 94.12% 94.11% -0.02%
==========================================
Files 160 160
Lines 5400 5418 +18
Branches 312 312
==========================================
+ Hits 5083 5099 +16
- Misses 261 263 +2
Partials 56 56
Continue to review full report at Codecov.
|
noisecapella
force-pushed
the
gs/coupon_update
branch
from
5e4f913 to
ed2b0a1
Compare
mbertrand
requested changes
May 17, 2019
There was a problem hiding this comment.
Works as described but I noticed an issue when I have an "auto" coupon that is valid for the product in my basket. If I clear out the coupon code and click "Apply", the auto coupon is added to the basket and applied to the price, but does not show up in the coupon input field, unless I refresh the page:
|
Ah, good catch. I'll investigate. |
noisecapella
force-pushed
the
gs/coupon_update
branch
from
ed2b0a1 to
414ba0f
Compare
|
I think that should fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Flight checklist
What are the relevant tickets?
Fixes #268
What's this PR do?
Fixes logic on frontend where the coupon code submitted and the one rendered in the text field were calculated differently.
How should this be manually tested?
Apply a coupon. Refresh the page. Click the "Apply" button next to the coupon code. Nothing should appear to change. If you look in the network tab you should see a successful PATCH to the basket with the coupon code. On master you would see the coupon being removed from the basket, which is incorrect.