Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry-image in concourse pipelines #1553

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

pt2302
Copy link
Contributor

@pt2302 pt2302 commented Oct 28, 2022

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

Closes #1550.

What's this PR do?

Updates the concourse pipeline definitions to use registry-image instead of docker-image. For additional background, please see https://github.com/concourse/registry-image-resource#comparison-to-docker-image-resource.

How should this be manually tested?

All of the relevant pipelines should be tested, ideally on both Apple Silicon and Intel processors, to make sure that no compatibility issues arise. Note that for Apple Silicon, we are using the rdclda/concourse:7.7.1 Docker image for concourse.

For example, to upsert the theme assets, execute docker-compose exec web ./manage.py upsert_theme_assets_pipeline --delete-all.

@pt2302 pt2302 changed the title Pt/concourse pipelines registry Use registry-image in concourse pipelines Oct 28, 2022
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works normally on my older intel-based mac

Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my m1!

Well, a little slow as we discussed on Friday.

@pt2302 pt2302 merged commit 4167fb2 into master Oct 31, 2022
@pt2302 pt2302 deleted the pt/concourse_pipelines_registry branch October 31, 2022 16:44
@odlbot odlbot mentioned this pull request Nov 1, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace docker-image with registry-image in concourse pipelines
4 participants