Improving handling of XCCDF fields that may contain HTML #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the stopNodes feature of fast-xml-parser to avoid parsing the HTML in these fields so they can be treated as text. The HTML tags are then stripped from the text as tools expect only text (and not HTML) in these fields. Signed-off-by: Craig Andrews <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
fantastic - that looks a lot better now! i'll merge when all the tests pass. could you also make a corresponding PR in the SAF CLI to update the xccdf sample files over there? |
Amndeep7
approved these changes
Sep 20, 2023
Amndeep7
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the stopNodes feature of fast-xml-parser to avoid parsing the HTML in these fields so they can be treated as text. The HTML tags are then stripped from the text as tools expect only text (and not HTML) in these fields.
This PR implements the idea first proposed at #4255 (comment) which is now possible because the
stopNodesfeature of fast-xml-parser was fixed in version 4.3.0 by NaturalIntelligence/fast-xml-parser#608