Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISA Excel Export column ordering is not consistent with the DISA provided STIGTemplate spreadsheet #659

Open
skykam87 opened this issue Mar 3, 2025 · 1 comment

Comments

@skykam87
Copy link

skykam87 commented Mar 3, 2025

A review of the column ordering on several DISA provided STIGTemplate spreadsheets indicates a consistent column ordering as follows:

'IA Control', 'CCI', 'SRGID', 'STIGID', 'SRG Requirement', 'Requirement', 'SRG VulDiscussion', 'VulDiscussion', 'Status', 'SRG Check', 'Check', 'SRG Fix', 'Fix', 'Severity', 'Mitigation', 'Artifact Description', 'Status Justification'

Vulcan column ordering for DISA Excel Exports is:

'IA Control', 'CCI', 'SRGID', 'STIGID', 'Severity', 'SRG Requirement', 'Requirement', 'SRG VulDiscussion', 'VulDiscussion', 'Status', 'SRG Check', 'Check', 'SRG Fix', 'Fix', 'Status Justification', 'Mitigation', 'Artifact Description', 'Vendor Comments'

The 'Severity', 'Mitigations', 'Status Justification', and 'Artifact Description' columns are out of order.

To correct this:
Update the ordering for the headers configured under vulcan/app/constants/export_constants.rb DISA_EXPORT_HEADERS.
Update the ordering for the records under vulcan/app/models/rule.rb, def csv_attributes.

This change affects the column ordering for CSV, Excel and DISA Excel Exports, as all 3 export methods use the same base header and record definitions. If non-DISA Excel Exports are required to follow the current column ordering, additional work will be necessary to break out the header and record definitions into unique definitions for each export type.

@aaronlippold
Copy link
Member

I will review this over the next day or two. Thank you for the issue and the PR! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants