Revised ordering of excel/csv output columns to align with DISA provided SRGTemplate spreadsheet. #660
Conversation
…ded SRGTemplate spreadsheet.
|
Resolves #659 |
|
@skykam87 Thank you for your contribution. I have enabled workflows in this PR, and it seems one of them is failing. Can you please make sure that all workflows are passing? |
|
@rlakey Hi Ryan, can you please take a look at this PR and related issue (#659)? Aaron suggested that you'd have the best expertise to confirm the accuracy of this change. Codewise, things look fine by me though I'd appreciate @vanessuniq chiming in if possible. |
@Amndeep7 Please rerun at your convenience. I adjusted my change to align to the 120 char max length per the projects coding standards. |
The column ordering I have in my most recent spreadsheets from 11/24 is slightly different than what is being proposed here. Mine are all... 'IA Control', 'CCI', 'SRGID', 'STIGID', 'SRG Requirement', 'Requirement', 'SRG VulDiscussion', 'VulDiscussion', 'Status', 'SRG Check', 'Check', 'SRG Fix', 'Fix', 'Severity', 'Mitigation', 'Artifact Description', 'Status Justification' |
…ectly match DISA template.
Ryan - you are correct. I must have neglected to transpose Status Justification and Artifact Description fields that were flipped in the original Vulcan output when I was comparing the DISA spreadsheets. I pushed an updated commit to fix these. Thanks for catching this! |
|
DISA Excel Export column ordering is not consistent with the DISA provided STIGTemplate spreadsheet.
A review of the column ordering on several DISA provided STIGTemplate spreadsheets indicates a consistent column ordering as follows:
'IA Control', 'CCI', 'SRGID', 'STIGID', 'SRG Requirement', 'Requirement', 'SRG VulDiscussion', 'VulDiscussion', 'Status', 'SRG Check', 'Check', 'SRG Fix', 'Fix', 'Severity', 'Mitigation', 'Artifact Description', 'Status Justification'
Vulcan column ordering for DISA Excel Exports is:
'IA Control', 'CCI', 'SRGID', 'STIGID', 'Severity', 'SRG Requirement', 'Requirement', 'SRG VulDiscussion', 'VulDiscussion', 'Status', 'SRG Check', 'Check', 'SRG Fix', 'Fix', 'Status Justification', 'Mitigation', 'Artifact Description', 'Vendor Comments'
The 'Severity', 'Mitigations', 'Status Justification', and 'Artifact Description' columns are out of order.
To correct this:
Update the ordering for the headers configured under vulcan/app/constants/export_constants.rb DISA_EXPORT_HEADERS.
Update the ordering for the records under vulcan/app/models/rule.rb, def csv_attributes.
This change affects the column ordering for CSV, Excel and DISA Excel Exports, as all 3 export methods use the same base header and record definitions. If non-DISA Excel Exports are required to follow the current column ordering, additional work will be necessary to break out the header and record definitions into unique definitions for each export type.