get-pipsi.py will now use the virtualenv installed in the python interpreter #91
Conversation
…rpreter Instead of searching for the virtualenv command, use the virtualenv that is installed in the python interpreter that is running ``python get-pipsi.py``. This will also fallback to using the ``venv`` package on python3. It's assumed if someone installed ``virtualenv`` then that overrides the default ``venv`` from the stdlib.
mmerickel
force-pushed
the
bootstrap-with-venv
branch
from
0424d3e to
be4abc4
Compare
|
Any chance this gets reviewed? |
|
looks good at first glance, could use an accompanying test we are looking for a new maintainer |
|
@RonnyPfannschmidt I might be interested in helping with the maintenance of this project but I'd want the ability to push pypi releases as it hasn't had one in quite some time. It is not super clear to me right now what the ultimate goals are for this project versus how much it is considered feature-complete. |
|
Apart from the fact there's no tests for a pretty substantial change, this looks good to me. pypi falling behind is a shame, and it would be great if a new maintainer had the ability to fix that, especially if there are no other maintainers. But given the recommended pipsi installation method, it's not the end of the world. |
Instead of searching for the virtualenv command, use the virtualenv that
is installed in the python interpreter that is running
python get-pipsi.py. This will also fallback to using thevenvpackage on python3. It's assumed if someone installed
virtualenvthen that overrides the default
venvfrom the stdlib.